Skip to content
This repository was archived by the owner on Oct 13, 2025. It is now read-only.

Conversation

@dacr
Copy link
Contributor

@dacr dacr commented May 27, 2020

Everything should be OK to cross publish (scala 2.12 & 2.13 artifacts) to maven central, check the publish.sbt configuration file. To cross publish to central just execute sbt release it will trigger all the process, even tagging and version.sbt file content update.

@dacr
Copy link
Contributor Author

dacr commented May 27, 2020

I've also added all the required changes linked to scala 2.13 refactored collections.

@rashtao
Copy link
Contributor

rashtao commented Jul 15, 2020

@dacr thanks for contributing!
Due to the nature of this library, we decided to keep different branches for each different Scala version and avoid cross compilation to different versions. This approach requires a bit more work for merging code changes to all branches, but it is safer and easier to maintain with respect to differences in collection API across many Scala versions.

Furthermore, since we don't need cross compilation, I guess there is no need to switch to sbt. We would like to keep the current mvn approach since it is already integrated in our internal CI.

I have created a new branch named release/velocypack-module-scala_2.12, so now master can be updated to Scala 2.13.

@rashtao
Copy link
Contributor

rashtao commented Jul 17, 2020

@dacr

We are obliged by law to have a signed scanned copy of a Contributor License Agreement (CLA) to be able to accept pull requests to the official ArangoDB repository - even for such small changes.

We use an Apache 2 CLA for ArangoDB and its companion projects, which can be found here: https://www.arangodb.com/documents/cla.pdf Just fill in the form, sign and send a scanned copy over to cla@arangodb.com

Thank you

@dacr
Copy link
Contributor Author

dacr commented Sep 20, 2020

@dacr

We are obliged by law to have a signed scanned copy of a Contributor License Agreement (CLA) to be able to accept pull requests to the official ArangoDB repository - even for such small changes.

We use an Apache 2 CLA for ArangoDB and its companion projects, which can be found here: https://www.arangodb.com/documents/cla.pdf Just fill in the form, sign and send a scanned copy over to cla@arangodb.com

Thank you

Just signed today, sorry for the delay,
regards,
David.

@rashtao rashtao self-requested a review September 21, 2020 09:30
Copy link
Contributor

@rashtao rashtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@rashtao rashtao merged commit 48cb014 into arangodb:master Sep 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants